Use CMake EXPORT #8954

swolchok · 2025-03-05T01:40:22Z

The CMake EXPORT feature makes target_compile_options/target_link_libraries etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. We are currently working around our lack of EXPORT by (incompletely and therefore incorrectly!) repeating our configuration in tools/cmake/executorch-config.cmake.

I was previously stalled here by XNNPACK's lack of use of EXPORT, but I found that this can be worked around by building those targets with ExternalProject!

[ghstack-poisoned]

swolchok · 2025-03-05T01:40:23Z

Stack from ghstack (oldest at bottom):

pytorch-bot · 2025-03-05T01:40:26Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8954

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 25 New Failures, 7 Pending, 1 Unrelated Failure

As of commit 2e1d1e4 with merge base 4d7f9ca ():

NEW FAILURES - The following jobs have failed:

Build Presets / apple (pybind) / build (gh)
pull / test-binary-size-linux / linux-job (gh)
RuntimeError: Command docker exec -t 2ebed741aad973fda5ea0e3af8b04018bc2f980debbd57afb62fd3ce72546e77 /exec failed with exit code 1
pull / test-binary-size-linux-gcc / linux-job (gh)
RuntimeError: Command docker exec -t f9609b5109963a979d7b659191e3915eac643178267df5d16f99eae2b7e8633c /exec failed with exit code 1
pull / test-eval_llama-mmlu-linux / linux-job (gh)
RuntimeError: Command docker exec -t 227425d653a1a8659beb8ad0441ab5a71ba11c2fdbf049249625c4bfd1039ecd /exec failed with exit code 1
pull / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (gh)
RuntimeError: Command docker exec -t dac3e289feabd902988b25d715f0579644ff7f8f480240a9ea1f29444a1104c3 /exec failed with exit code 2
pull / test-llama-runner-qnn-linux (fp32, qnn_8a8w, qnn) / linux-job (gh)
RuntimeError: Command docker exec -t 2a875ecf6dee851e49b0a9db3fb0ca44e42f9864e3fda966eccb9ed8942ab1a8 /exec failed with exit code 2
pull / test-phi-3-mini-runner-linux / linux-job (gh)
RuntimeError: Command docker exec -t 2218c534e8f88188e503d0886e1b2dabb3f8ca602cc9ce082cec867d3e475536 /exec failed with exit code 1
pull / test-static-llama-qnn-linux / linux-job (gh)
RuntimeError: Command docker exec -t 6a3be5974bd2e17e892658a9b3bd996859296db91a46289af4fee6ce07d5df1a /exec failed with exit code 2
pull / unittest / linux / linux-job (gh)
RuntimeError: Command docker exec -t c119f1e50f942d513915c4bc05b6e2430551c499fd969b11c807e965d7fe28e2 /exec failed with exit code 1
trunk / test-arm-cortex-m-size-test (bare_metal) / linux-job (gh)
RuntimeError: Command docker exec -t 35cbda3bd2fd7dc6c29a9088b1d7ba054ba9c9d64efb9e7f54b8bc36ff71bf6c /exec failed with exit code 1
trunk / test-arm-cortex-m-size-test (zephyr-preset) / linux-job (gh)
RuntimeError: Command docker exec -t 8ace84fe55bc675403e2ea5694f57036b4d68f107ef7f600bf719600007077c8 /exec failed with exit code 1
trunk / test-llama-runner-qnn-linux (fp32, qnn_16a16w, qnn) / linux-job (gh)
RuntimeError: Command docker exec -t 68236ce804843a52b9c18a26470972a80036653f952ded0a6d9216bb14f56232 /exec failed with exit code 2
trunk / test-llama-runner-qnn-linux (fp32, qnn_8a8w, qnn) / linux-job (gh)
RuntimeError: Command docker exec -t 3b305f47e289cdc39300c3e4c0d9488babe576e5d5e5ade06dfddfe803442427 /exec failed with exit code 2
trunk / test-qnn-model (fp32, dl3) / linux-job (gh)
RuntimeError: Command docker exec -t 88384a1c039fa0351465546bdcbd1f655ac3dc0fa54b980407da25319d300f70 /exec failed with exit code 2
trunk / test-qnn-model (fp32, ic3) / linux-job (gh)
RuntimeError: Command docker exec -t f926dd0162f66647bfc05423734f7398b32555d50e344f8b20b9d8a9c892cfdf /exec failed with exit code 2
trunk / test-qnn-model (fp32, ic4) / linux-job (gh)
RuntimeError: Command docker exec -t c253f0736fb1793042b5d2d4bd39d6d1a43d9c1e13ccc3e33513583bbf4c9e0f /exec failed with exit code 2
trunk / test-qnn-model (fp32, mb) / linux-job (gh)
RuntimeError: Command docker exec -t 554c86de954bfd43414c8a7599c1d91233dc9bea61d6383c37a0e9a6572caf26 /exec failed with exit code 2
trunk / test-qnn-model (fp32, mv2) / linux-job (gh)
RuntimeError: Command docker exec -t cc1d38cdd2dad29dd30929109f2acfaa5d6989647fba982c9e97672fd454164d /exec failed with exit code 2
trunk / test-qnn-model (fp32, mv3) / linux-job (gh)
RuntimeError: Command docker exec -t 472c2069e83a21fb0c21053c1bf6eb17e811bd045c65582622e6890e3ae61b20 /exec failed with exit code 2
trunk / test-qnn-model (fp32, vit) / linux-job (gh)
RuntimeError: Command docker exec -t c29ddef1ed23d9a1cfc496f7426f5b8bee5b656b419c161c6ab2ae34fa08aae5 /exec failed with exit code 2
trunk / test-qnn-model (fp32, w2l) / linux-job (gh)
RuntimeError: Command docker exec -t 20f34626960776743765cc396ed9493cc88ccef7b39b09d24b30db3fdd43f2fe /exec failed with exit code 2
trunk / test-qnn-optimum-model (fp32, albert) / linux-job (gh)
RuntimeError: Command docker exec -t 72403ca8218c20d7f7f5727a8b7f363c1371de4c206b82eaed5994719c83b92d /exec failed with exit code 2
trunk / test-qnn-optimum-model (fp32, bert) / linux-job (gh)
RuntimeError: Command docker exec -t 4a932c45a38ff24b8bc98c696530996aed7ba2f74e6194930738b9c78f30d39a /exec failed with exit code 2
trunk / test-qnn-optimum-model (fp32, distilbert) / linux-job (gh)
RuntimeError: Command docker exec -t 639350aef391dbcf82d02fe93d1d69673ec74564d208f6d303161eb37a015c6e /exec failed with exit code 2
trunk / unittest-release / linux / linux-job (gh)
RuntimeError: Command docker exec -t 42a87839a6b6173cf4bad8cacc4a178caa2b58320255ce541bcdfea67e11cbb4 /exec failed with exit code 1

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / unittest-editable / linux / linux-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: e3e5b36 ghstack-comment-id: 2699501745 Pull Request resolved: #8954

github-actions · 2025-03-05T01:41:02Z

This PR needs a `release notes:` label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

swolchok · 2025-07-14T21:20:37Z

have an update cooking, need to make sure check whether warnings I'm seeing about macOS version mismatch during install_executorch.sh are new and if so problematic

[ghstack-poisoned]

The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: af3cc8d ghstack-comment-id: 2699501745 Pull Request resolved: #8954

[ghstack-poisoned]

The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: 16c0343 ghstack-comment-id: 2699501745 Pull Request resolved: #8954

[ghstack-poisoned]

The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: 2f0620d ghstack-comment-id: 2699501745 Pull Request resolved: #8954

[ghstack-poisoned]

The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: 742fd2f ghstack-comment-id: 2699501745 Pull Request resolved: #8954

[ghstack-poisoned]

The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: d71d97f ghstack-comment-id: 2699501745 Pull Request resolved: #8954

[ghstack-poisoned]

The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: f733c8c ghstack-comment-id: 2699501745 Pull Request resolved: #8954

[ghstack-poisoned]

The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: 2712a70 ghstack-comment-id: 2699501745 Pull Request resolved: #8954

swolchok · 2025-07-18T22:22:18Z

test-binary-size-linux regression is real. text size was 35810 before and is now 43358.

[ghstack-poisoned]

The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: 7d8ea62 ghstack-comment-id: 2699501745 Pull Request resolved: #8954

[ghstack-poisoned]

The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: fb57c08 ghstack-comment-id: 2699501745 Pull Request resolved: #8954

[ghstack-poisoned]

The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: cdcf948 ghstack-comment-id: 2699501745 Pull Request resolved: #8954

swolchok · 2025-07-19T22:05:34Z

I think the size regression is the same old "now we are counting register_prim_ops" fake regression from #12320, and I think we should just accept it and move the goalpost, since it is caused by building the size test the same way we build internally. If this really isn't what we want, then we should stop using force_load/whole_archive on the top-level ExecuTorch target, but I strongly suspect that that is not what we want. CC @mergennachin

[ghstack-poisoned]

The CMake EXPORT feature seems like it's supposed to make target_compile_options etc. work nicely for both in-project builds and also projects that consume your project by installing it and finding it with find_package. Using EXPORT would make it easy to have similar behavior to Buck's exported_preprocessor_flags, for example. Unfortunately, I am currently stalled here by XNNPACK's lack of use of EXPORT. I tried working around dependencies that don't use EXPORT by re-installing them with EXPORT ourselves, but XNNPACK has rather a lot so I'm sending this out to highlight the problem and ask if there's another way. I found some similar issues in TFLite: tensorflow/tensorflow#57658 tensorflow/tensorflow#87172 ghstack-source-id: 07c4720 ghstack-comment-id: 2699501745 Pull Request resolved: #8954

Update

6d51bff

[ghstack-poisoned]

swolchok requested review from dbort, JacobSzwejbka, lucylq, manuelcandales, kimishpatel, shoumikhin, jackzhxng, iseeyuan, larryliu0820, digantdesai, mcr229, SS-JIA and cccclai as code owners March 5, 2025 01:40

facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 5, 2025

swolchok marked this pull request as draft March 5, 2025 01:40

github-actions bot mentioned this pull request Mar 10, 2025

Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#16

Open

This was referenced Mar 17, 2025

Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#18

Open

Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#20

Open

github-actions bot mentioned this pull request Mar 31, 2025

Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#22

Open

github-actions bot mentioned this pull request Apr 7, 2025

Weekly pr metrics report - 2025-03-01..2025-03-07 wdvr/pytorch#26

Open

Update

b87d2fb

[ghstack-poisoned]

This was referenced Jul 14, 2025

[easy] cmake-format CMakeLists.txt #12450

Merged

[easy] cmake-format extension/training/CMakeLists.txt #12451

Merged

swolchok added 2 commits July 16, 2025 17:50

Update

4ac87e3

[ghstack-poisoned]

Update

0c7f574

[ghstack-poisoned]

swolchok changed the base branch from gh/swolchok/515/head to gh/swolchok/516/head July 17, 2025 00:52

swolchok mentioned this pull request Jul 17, 2025

Don't use iOS toolchain on macOS #12578

Closed

Update

200b7dd

[ghstack-poisoned]

Update

b85ed41

[ghstack-poisoned]

Update

5f121b7

[ghstack-poisoned]

swolchok changed the base branch from gh/swolchok/516/head to gh/swolchok/517/head July 17, 2025 22:30

swolchok mentioned this pull request Jul 17, 2025

append to CMAKE_PREFIX_PATH instead of setting executorch_DIR #12618

Open

Update

b0094c1

[ghstack-poisoned]

Update

2556e9a

[ghstack-poisoned]

Update

9a5096c

[ghstack-poisoned]

Update

d9517d8

[ghstack-poisoned]

swolchok mentioned this pull request Jul 19, 2025

[easy] Allow user to set ANDROID_NDK in build_llama_android script #12662

Open

rebase

92548b6

[ghstack-poisoned]

Update

2e1d1e4

[ghstack-poisoned]

swolchok changed the base branch from gh/swolchok/517/head to gh/swolchok/522/head July 21, 2025 01:37

swolchok mentioned this pull request Jul 21, 2025

Prefix target_link_options_shared_lib with ExecuTorch #12667

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use CMake EXPORT #8954

Use CMake EXPORT #8954

swolchok commented Mar 5, 2025 •

edited

Loading

Uh oh!

swolchok commented Mar 5, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Mar 5, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 5, 2025

Uh oh!

swolchok commented Jul 14, 2025

Uh oh!

swolchok commented Jul 18, 2025

Uh oh!

swolchok commented Jul 19, 2025

Uh oh!

Uh oh!

Use CMake EXPORT #8954

Are you sure you want to change the base?

Use CMake EXPORT #8954

Conversation

swolchok commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

swolchok commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8954

❌ 25 New Failures, 7 Pending, 1 Unrelated Failure

Uh oh!

github-actions bot commented Mar 5, 2025

This PR needs a release notes: label

Uh oh!

swolchok commented Jul 14, 2025

Uh oh!

swolchok commented Jul 18, 2025

Uh oh!

swolchok commented Jul 19, 2025

Uh oh!

Uh oh!

swolchok commented Mar 5, 2025 •

edited

Loading

swolchok commented Mar 5, 2025 •

edited

Loading

pytorch-bot bot commented Mar 5, 2025 •

edited

Loading

This PR needs a `release notes:` label